From 90ee26dd2d0a58f67b243148772028f8c20bbc82 Mon Sep 17 00:00:00 2001
From: Julian Oes <julian@oes.ch>
Date: Wed, 24 Apr 2019 11:00:55 +0200
Subject: [PATCH] mavlink_mission: properly initialize padding
This prevents uninitialized padding from being written to dataman.
---
src/modules/mavlink/mavlink_mission.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/modules/mavlink/mavlink_mission.cpp b/src/modules/mavlink/mavlink_mission.cpp
index 06614ed4fe..09e1be405c 100644
--- a/src/modules/mavlink/mavlink_mission.cpp
+++ b/src/modules/mavlink/mavlink_mission.cpp
@@ -158,7 +158,8 @@ MavlinkMissionManager::load_safepoint_stats()
int
MavlinkMissionManager::update_active_mission(dm_item_t dataman_id, uint16_t count, int32_t seq)
{
- mission_s mission;
+ // We want to make sure the whole struct is initialized including padding before getting written by dataman.
+ mission_s mission {};
mission.timestamp = hrt_absolute_time();
mission.dataman_id = dataman_id;
mission.count = count;
--
GitLab