From f6cf95cee06006e465f0aa05b26687c240a873ea Mon Sep 17 00:00:00 2001
From: bazooka joe <bazookajoe1900@gmail.com>
Date: Wed, 26 Dec 2018 20:58:05 +0200
Subject: [PATCH] mavlink: fix uninitialized messages fields zeroed
uninitialized fields on home_position, mavlink_rc_channels_override,
mavlink_mission_item, mavlink_mission_item_int
---
src/modules/mavlink/mavlink_messages.cpp | 4 +++-
src/modules/mavlink/mavlink_mission.cpp | 4 ++--
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/modules/mavlink/mavlink_messages.cpp b/src/modules/mavlink/mavlink_messages.cpp
index b9cdfcd156..7fa642696c 100644
--- a/src/modules/mavlink/mavlink_messages.cpp
+++ b/src/modules/mavlink/mavlink_messages.cpp
@@ -2688,6 +2688,8 @@ protected:
msg.approach_y = 0.0f;
msg.approach_z = 0.0f;
+ msg.time_usec = hrt_absolute_time();
+
mavlink_msg_home_position_send_struct(_mavlink->get_channel(), &msg);
return true;
@@ -3407,7 +3409,7 @@ protected:
/* send override message - harmless if connected to GCS, allows to connect a board to a Linux system */
/* http://mavlink.org/messages/common#RC_CHANNELS_OVERRIDE */
- mavlink_rc_channels_override_t over;
+ mavlink_rc_channels_override_t over = {};
over.target_system = mavlink_system.sysid;
over.target_component = 0;
over.chan1_raw = msg.chan1_raw;
diff --git a/src/modules/mavlink/mavlink_mission.cpp b/src/modules/mavlink/mavlink_mission.cpp
index 5a5b7c674b..a0faa69e28 100644
--- a/src/modules/mavlink/mavlink_mission.cpp
+++ b/src/modules/mavlink/mavlink_mission.cpp
@@ -368,7 +368,7 @@ MavlinkMissionManager::send_mission_item(uint8_t sysid, uint8_t compid, uint16_t
_time_last_sent = hrt_absolute_time();
if (_int_mode) {
- mavlink_mission_item_int_t wp;
+ mavlink_mission_item_int_t wp = {};
format_mavlink_mission_item(&mission_item, reinterpret_cast<mavlink_mission_item_t *>(&wp));
wp.target_system = sysid;
@@ -381,7 +381,7 @@ MavlinkMissionManager::send_mission_item(uint8_t sysid, uint8_t compid, uint16_t
PX4_DEBUG("WPM: Send MISSION_ITEM_INT seq %u to ID %u", wp.seq, wp.target_system);
} else {
- mavlink_mission_item_t wp;
+ mavlink_mission_item_t wp = {};
format_mavlink_mission_item(&mission_item, &wp);
wp.target_system = sysid;
--
GitLab