Skip to content
Snippets Groups Projects
Commit 1ca05aaa authored by Mark Charlebois's avatar Mark Charlebois Committed by Lorenz Meier
Browse files

orb_advert_t changed to void * and checks changed to nullptr


The existing orb_advert_t use thoughout the code sometimes tries
to treat it as a file descriptor and there are checks for < 0
and ::close calls on orb_advert_t types which is an invalid use
of an object pointer, which is what orb_advert_t really is.

Initially I had changed the -1 initializations to 0 but it was
suggested that this should be nullptr. That was a good recommendation
but the definition of orb_advert_t had to change to void * because
you cannot initialize a uintptr_t as nullptr.

Signed-off-by: default avatarMark Charlebois <charlebm@gmail.com>
parent 180c8b0c
No related branches found
No related tags found
No related merge requests found
Showing
with 61 additions and 66 deletions
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment