Skip to content
Snippets Groups Projects
  1. Nov 21, 2018
  2. Nov 16, 2018
  3. Nov 14, 2018
  4. Nov 13, 2018
    • Mara Bos's avatar
      Use unix sockets instead of pipes for posix daemon. (#10766) · 9594ebf7
      Mara Bos authored
      Unlike pipes, unix sockets provide bi-directional
      communication with each connected client.
      
      - No need to generate a unique uuid per client anymore.
      
      - The client doesn't have to create its own pipe anymore.
      
      - Since there is no risk of multiple client's writes getting mixed up,
        messages don't need to fit in a single write anymore, removing the
        limit on command length.
      
      - Since the server can detect a connection closing, the client no longer
        needs to handle signals. When the client is killed, the connection is
        automatically closed, which will cause the server to kill the related
        px4 thread.
        Since this does not rely on handling signals and the client sending an
        additional message, this is much more reliable.
      
      - Client is no longer a singleton.
      
      - The protocol is simplified. Standard output is directly written to the
        socket back to the client, without wrapping it in any protocol
        message.
      
      - Because of the simple protocol, one could now even use netcat to run a
        px4 command:
      
          $ echo hello | netcat -UN /tmp/px4-sock-0
      
      Also removes a few race conditions.
      9594ebf7
  5. Nov 10, 2018
  6. Oct 27, 2018
    • Mara Bos's avatar
      Fix many format strings. · 10c20b38
      Mara Bos authored
      Fixes these invalid format strings:
      - A `%d` for a pointer (replaced it by `%p`)
      - A 0x%08x (and a 0x%0x8!) for a pointer (replaced by %p)
      - 2 cases of `%d` for a `ssize_t` (replaced it by `%zi`)
      - 1 case of a %u for an `int` (replaced by %i)
      - 3 cases of %d for a `long` (replaced by %ld)
      - 19 cases of `%d`, `%i`, `%u` or `%lu` for a `size_t` (replaced it by `%zu`)
      - An unused formatting argument (removed it)
      - A missing `%d` (added it)
      - A missing `%s` (added it)
      - 2 cases of `%llu` for a `uint64_t` (replaced it by `"%" PRIu64`)
      - 6 cases of giving a string directly as format string (replaced it by `("%s", string)`)
      - 2 cases of %*-s, which should probably have been %-*s.
        (Looks like NuttX accepts (the invalid) %*-s, but other platforms don't.)
      - A %04x for a `uint32_t` (replaced by "%04" PRIx32)
      10c20b38
  7. Oct 20, 2018
  8. Oct 15, 2018
  9. Oct 09, 2018
  10. Oct 03, 2018
  11. Sep 27, 2018
    • Beat Küng's avatar
      posix shell: use /bin/sh instead of bash · b972651a
      Beat Küng authored
      This uses the systems default shell:
      - Ubuntu: dash
      - Fedora: bash
      
      Since bash is invoked via /bin/sh, it operates in POSIX mode:
        https://tiswww.case.edu/php/chet/bash/POSIX
      
      - remove '# Ignore the expand_aliases command in zshell.'
        Not needed because the shell operates in POSIX mode
      - [[ is bashism -> use [
      - autostart_files=( $autostart_file_match )
        is not supported in dash, so use 'ls'
      - shellcheck runs the dash flavor, since dash is a minimalistic shell.
      
      Tested on dash & bash.
      b972651a
  12. Sep 26, 2018
  13. Sep 25, 2018
    • David Sidrane's avatar
      tap-v1 nsh: Disable ARCH_IRQPRIO & ARCH_HIPRI_INTERRUP · 6ec693b7
      David Sidrane authored
         This insures the common exception handler will not be
         re-entered. The handler does not support nested interrupts
         and the interrupt stack pointer and context will be overwritten
         resulting in hard to debug hardfaults.
      
         If all the priorities are equal the NVIC prevents the
         preemption. The startup code defaults all the priorities
         to the same value 128.
      
         This change safeguards in 2 ways 1) By disabling
         CONFIG_ ARCH_IRQPRIO: up_prioritize_irq cannot be called.
         This will insure that all HW interrupts are at the same
         priority.
      
         2) By disabling CONFIG_ARCH_HIPRI_INTERRUP, the common
         exception will disable any interrupts during interrupt
         processing.
      6ec693b7
    • David Sidrane's avatar
      px4nucleoF767ZI-v1 nsh: Disable ARCH_IRQPRIO & ARCH_HIPRI_INTERRUP · 3f1a155e
      David Sidrane authored
         This insures the common exception handler will not be
         re-entered. The handler does not support nested interrupts
         and the interrupt stack pointer and context will be overwritten
         resulting in hard to debug hardfaults.
      
         If all the priorities are equal the NVIC prevents the
         preemption. The startup code defaults all the priorities
         to the same value 128.
      
         This change safeguards in 2 ways 1) By disabling
         CONFIG_ ARCH_IRQPRIO: up_prioritize_irq cannot be called.
         This will insure that all HW interrupts are at the same
         priority.
      
         2) By disabling CONFIG_ARCH_HIPRI_INTERRUP, the common
         exception will disable any interrupts during interrupt
         processing.
      3f1a155e
    • David Sidrane's avatar
      px4fmu-v5 stackcheck: Disable ARCH_IRQPRIO & ARCH_HIPRI_INTERRUP · f7dd2511
      David Sidrane authored
         This insures the common exception handler will not be
         re-entered. The handler does not support nested interrupts
         and the interrupt stack pointer and context will be overwritten
         resulting in hard to debug hardfaults.
      
         If all the priorities are equal the NVIC prevents the
         preemption. The startup code defaults all the priorities
         to the same value 128.
      
         This change safeguards in 2 ways 1) By disabling
         CONFIG_ ARCH_IRQPRIO: up_prioritize_irq cannot be called.
         This will insure that all HW interrupts are at the same
         priority.
      
         2) By disabling CONFIG_ARCH_HIPRI_INTERRUP, the common
         exception will disable any interrupts during interrupt
         processing.
      f7dd2511
    • David Sidrane's avatar
      px4fmu-v5 nsh: Disable ARCH_IRQPRIO & ARCH_HIPRI_INTERRUP · a6e77eb9
      David Sidrane authored
         This insures the common exception handler will not be
         re-entered. The handler does not support nested interrupts
         and the interrupt stack pointer and context will be overwritten
         resulting in hard to debug hardfaults.
      
         If all the priorities are equal the NVIC prevents the
         preemption. The startup code defaults all the priorities
         to the same value 128.
      
         This change safeguards in 2 ways 1) By disabling
         CONFIG_ ARCH_IRQPRIO: up_prioritize_irq cannot be called.
         This will insure that all HW interrupts are at the same
         priority.
      
         2) By disabling CONFIG_ARCH_HIPRI_INTERRUP, the common
         exception will disable any interrupts during interrupt
         processing.
      a6e77eb9
    • David Sidrane's avatar
      px4fmu-v4pro nsh: Disable ARCH_IRQPRIO & ARCH_HIPRI_INTERRUP · a302c58a
      David Sidrane authored
         This insures the common exception handler will not be
         re-entered. The handler does not support nested interrupts
         and the interrupt stack pointer and context will be overwritten
         resulting in hard to debug hardfaults.
      
         If all the priorities are equal the NVIC prevents the
         preemption. The startup code defaults all the priorities
         to the same value 128.
      
         This change safeguards in 2 ways 1) By disabling
         CONFIG_ ARCH_IRQPRIO: up_prioritize_irq cannot be called.
         This will insure that all HW interrupts are at the same
         priority.
      
         2) By disabling CONFIG_ARCH_HIPRI_INTERRUP, the common
         exception will disable any interrupts during interrupt
         processing.
      a302c58a
    • David Sidrane's avatar
      px4fmu-v4 stackcheck: Disable ARCH_IRQPRIO & ARCH_HIPRI_INTERRUP · 825d6c06
      David Sidrane authored
         This insures the common exception handler will not be
         re-entered. The handler does not support nested interrupts
         and the interrupt stack pointer and context will be overwritten
         resulting in hard to debug hardfaults.
      
         If all the priorities are equal the NVIC prevents the
         preemption. The startup code defaults all the priorities
         to the same value 128.
      
         This change safeguards in 2 ways 1) By disabling
         CONFIG_ ARCH_IRQPRIO: up_prioritize_irq cannot be called.
         This will insure that all HW interrupts are at the same
         priority.
      
         2) By disabling CONFIG_ARCH_HIPRI_INTERRUP, the common
         exception will disable any interrupts during interrupt
         processing.
      825d6c06
    • David Sidrane's avatar
      px4fmu-v4 nsh: Disable ARCH_IRQPRIO & ARCH_HIPRI_INTERRUP · dfc390bb
      David Sidrane authored
         This insures the common exception handler will not be
         re-entered. The handler does not support nested interrupts
         and the interrupt stack pointer and context will be overwritten
         resulting in hard to debug hardfaults.
      
         If all the priorities are equal the NVIC prevents the
         preemption. The startup code defaults all the priorities
         to the same value 128.
      
         This change safeguards in 2 ways 1) By disabling
         CONFIG_ ARCH_IRQPRIO: up_prioritize_irq cannot be called.
         This will insure that all HW interrupts are at the same
         priority.
      
         2) By disabling CONFIG_ARCH_HIPRI_INTERRUP, the common
         exception will disable any interrupts during interrupt
         processing.
      dfc390bb
    • David Sidrane's avatar
      px4fmu-v2 stackcheck: Disable ARCH_IRQPRIO & ARCH_HIPRI_INTERRUP · 2ec56cef
      David Sidrane authored
         This insures the common exception handler will not be
         re-entered. The handler does not support nested interrupts
         and the interrupt stack pointer and context will be overwritten
         resulting in hard to debug hardfaults.
      
         If all the priorities are equal the NVIC prevents the
         preemption. The startup code defaults all the priorities
         to the same value 128.
      
         This change safeguards in 2 ways 1) By disabling
         CONFIG_ ARCH_IRQPRIO: up_prioritize_irq cannot be called.
         This will insure that all HW interrupts are at the same
         priority.
      
         2) By disabling CONFIG_ARCH_HIPRI_INTERRUP, the common
         exception will disable any interrupts during interrupt
         processing.
      2ec56cef
    • David Sidrane's avatar
      px4fmu-v2 nsh: Disable ARCH_IRQPRIO & ARCH_HIPRI_INTERRUP · 5148d2d9
      David Sidrane authored
         This insures the common exception handler will not be
         re-entered. The handler does not support nested interrupts
         and the interrupt stack pointer and context will be overwritten
         resulting in hard to debug hardfaults.
      
         If all the priorities are equal the NVIC prevents the
         preemption. The startup code defaults all the priorities
         to the same value 128.
      
         This change safeguards in 2 ways 1) By disabling
         CONFIG_ ARCH_IRQPRIO: up_prioritize_irq cannot be called.
         This will insure that all HW interrupts are at the same
         priority.
      
         2) By disabling CONFIG_ARCH_HIPRI_INTERRUP, the common
         exception will disable any interrupts during interrupt
         processing.
      5148d2d9
    • David Sidrane's avatar
      px4flow-v2 nsh: Disable ARCH_IRQPRIO & ARCH_HIPRI_INTERRUP · b6068977
      David Sidrane authored
         This insures the common exception handler will not be
         re-entered. The handler does not support nested interrupts
         and the interrupt stack pointer and context will be overwritten
         resulting in hard to debug hardfaults.
      
         If all the priorities are equal the NVIC prevents the
         preemption. The startup code defaults all the priorities
         to the same value 128.
      
         This change safeguards in 2 ways 1) By disabling
         CONFIG_ ARCH_IRQPRIO: up_prioritize_irq cannot be called.
         This will insure that all HW interrupts are at the same
         priority.
      
         2) By disabling CONFIG_ARCH_HIPRI_INTERRUP, the common
         exception will disable any interrupts during interrupt
         processing.
      b6068977
    • David Sidrane's avatar
      px4esc-v1 nsh: Disable ARCH_IRQPRIO & ARCH_HIPRI_INTERRUP · ee28b9aa
      David Sidrane authored
         This insures the common exception handler will not be
         re-entered. The handler does not support nested interrupts
         and the interrupt stack pointer and context will be overwritten
         resulting in hard to debug hardfaults.
      
         If all the priorities are equal the NVIC prevents the
         preemption. The startup code defaults all the priorities
         to the same value 128.
      
         This change safeguards in 2 ways 1) By disabling
         CONFIG_ ARCH_IRQPRIO: up_prioritize_irq cannot be called.
         This will insure that all HW interrupts are at the same
         priority.
      
         2) By disabling CONFIG_ARCH_HIPRI_INTERRUP, the common
         exception will disable any interrupts during interrupt
         processing.
      ee28b9aa
    • David Sidrane's avatar
      px4cannode-v1 nsh: Disable ARCH_IRQPRIO & ARCH_HIPRI_INTERRUP · 65322c98
      David Sidrane authored
         This insures the common exception handler will not be
         re-entered. The handler does not support nested interrupts
         and the interrupt stack pointer and context will be overwritten
         resulting in hard to debug hardfaults.
      
         If all the priorities are equal the NVIC prevents the
         preemption. The startup code defaults all the priorities
         to the same value 128.
      
         This change safeguards in 2 ways 1) By disabling
         CONFIG_ ARCH_IRQPRIO: up_prioritize_irq cannot be called.
         This will insure that all HW interrupts are at the same
         priority.
      
         2) By disabling CONFIG_ARCH_HIPRI_INTERRUP, the common
         exception will disable any interrupts during interrupt
         processing.
      65322c98
    • David Sidrane's avatar
      px4cannode-v1 nsh: Disable ARCH_IRQPRIO & ARCH_HIPRI_INTERRUP · 384a1dcf
      David Sidrane authored
         This insures the common exception handler will not be
         re-entered. The handler does not support nested interrupts
         and the interrupt stack pointer and context will be overwritten
         resulting in hard to debug hardfaults.
      
         If all the priorities are equal the NVIC prevents the
         preemption. The startup code defaults all the priorities
         to the same value 128.
      
         This change safeguards in 2 ways 1) By disabling
         CONFIG_ ARCH_IRQPRIO: up_prioritize_irq cannot be called.
         This will insure that all HW interrupts are at the same
         priority.
      
         2) By disabling CONFIG_ARCH_HIPRI_INTERRUP, the common
         exception will disable any interrupts during interrupt
         processing.
      384a1dcf
Loading