- fixes Coverity CID 328485

 - fixes Coverity CID 328492

 - fixes Coverity CID 332544

Signed-off-by: CarlOlsson <carlolsson.co@gmail.com>

    - mavlink v2.0 in PX4/Firmware (8f45c4f9ac1391a7519f633ed654cc41c54cafaa): https://github.com/mavlink/c_library_v2/commit/bf68eed6f6819ca1eca44217955794af554d0369
    - mavlink v2.0 current upstream: https://github.com/mavlink/c_library_v2/commit/f073569b746b6533c1715b0bbfed6c988444b257
    - Changes: https://github.com/mavlink/c_library_v2/compare/bf68eed6f6819ca1eca44217955794af554d0369...f073569b746b6533c1715b0bbfed6c988444b257

    - sitl_gazebo in PX4/Firmware (4e792b24): https://github.com/PX4/sitl_gazebo/commit/b34a96e7e5572209d21b9445be048c77ef041baa
    - sitl_gazebo current upstream: https://github.com/PX4/sitl_gazebo/commit/2e80474653bcb7808a7dfced4cf403ef607d69da
    - Changes: https://github.com/PX4/sitl_gazebo/compare/b34a96e7e5572209d21b9445be048c77ef041baa...2e80474653bcb7808a7dfced4cf403ef607d69da

    2e80474 2019-02-18 Elia Tarasov - fix comment for mag strength table unit
9a9a137 2019-02-18 Elia Tarasov - fix comment for the file name
7c49b2f 2019-02-18 Elia Tarasov - add units to mag variables
c004d94 2019-02-18 Elia Tarasov - fix magnetic field calculation by using geo lookup table
e9a3940 2019-02-18 Elia Tarasov - fix comment on magnetic data source and properties
c76ac17 2019-02-18 Elia Tarasov - copy magnetic data tables and functions from ecl/geo_lookup
28f59c5 2019-02-18 Elia Tarasov - add constrain function
8c869ed 2019-02-18 Elia Tarasov - fix linker complain on multiple definitions
b5213a7 2019-02-18 Elia Tarasov - add getters for mag inclination and strength
d311233 2019-02-15 Elia Tarasov - fix D-component of magnetic field for Zurich according to WMM2015

Problem description at: http://discuss.px4.io/t/multicopter-lock-if-primary-gyro-fails/9685

- Accel: use cutoff of 62.5 Hz instead of 500 Hz
- Gyro: the cutoff frequency is coupled with the ODR and is fixed to 116 Hz
  at 1 kHz readout rate. So this patch does not change anything for the
  gyro.

Move variable initializations to header file that were no longer in the correct order in the constructor list.

Deprecate #defines that are not needed, format whitespace and minor (incomplete) alphebetization of a few lists.

There is only one occurence of the namespace specified,
so it's more readable to simply specify the full namespace in this case.

Because BATT_SMBUS is using a different structure (the ModuleBase class), and `BATT_SMBUS::task_spawn` is only called for the `start` command. This is the reason why you don't need to check for it in here.

Co-Authored-By: BazookaJoe1900 <BazookaJoe1900@gmail.com>

Co-Authored-By: BazookaJoe1900 <BazookaJoe1900@gmail.com>

Co-Authored-By: BazookaJoe1900 <BazookaJoe1900@gmail.com>

Co-Authored-By: BazookaJoe1900 <BazookaJoe1900@gmail.com>

Co-Authored-By: BazookaJoe1900 <BazookaJoe1900@gmail.com>

using only <px4_getopt.h> as include, cleanup related includes
added check that all the option are valid (myoptind >= argc). if there are invalid options on some script that might now lead not to run commands

the mode can be used for VIO algorithms and obstacle avoidance to close the loop

Add perf_free() calls orb_unsubscribe and remove delete _instance in the Simulator class destructor.

Move remaining variable initialization from constructor list and alphabetize/organize methods and vars ordering.

 - closes #10133